Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Value Tracking should ignore optional parameters that aren't specified #66771

Closed
davidwengier opened this issue Feb 9, 2023 · 0 comments · Fixed by #76318
Closed

Value Tracking should ignore optional parameters that aren't specified #66771

davidwengier opened this issue Feb 9, 2023 · 0 comments · Fixed by #76318
Assignees
@ToddGrun
Labels
Area-IDE Feature - IDE Value Tracking Work being done for Value Tracking in the IDE
Milestone
Backlog

Comments

@davidwengier
Copy link
Member

I'm in the constructor for CodeGenerationContext, and I want to know where the afterThisLocation optional parameter is used. If I right click on it, and select Track Value Source I get this:

image

This is no more useful than just a Find All Refs on the constructor. It should know that since I asked about the source of the afterThisLocation parameter, I only want to see the calls where that parameter has been supplied as an argument in some way.

(Aside: The right hand panel of this window takes up so much space, but is completely useless. Can it be moved to the top, so its horizontal? Or have a little editor window or something? In general this feature feels like it needs love)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 9, 2023
@ryzngard ryzngard added the Feature - IDE Value Tracking Work being done for Value Tracking in the IDE label Apr 27, 2023
@arunchndr arunchndr added this to the 17.8 P4 milestone Aug 7, 2023
@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 7, 2023
@arunchndr arunchndr modified the milestones: 17.8 P4, Backlog Nov 13, 2024
ToddGrun added a commit that referenced this issue Dec 7, 2024
@ToddGrun
Fixes #66771
7643f92 
Change the value tracking code such that parameters only add callers that specify that parameter as an argument.
@ToddGrun ToddGrun mentioned this issue Dec 7, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ToddGrun ToddGrun

Labels
Area-IDE Feature - IDE Value Tracking Work being done for Value Tracking in the IDE
Projects
None yet
Milestone
Backlog
4 participants
@ryzngard @davidwengier @ToddGrun @arunchndr