Change value tracking to verify a parameter is used when mapping from that parameter to it's callers #76318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
commented
Dec 7, 2024
src/Features/Core/Portable/ValueTracking/ValueTracker.FindReferencesProgress.cs
Outdated
Show resolved
Hide resolved
| if (syntaxFacts.IsArgument(descendantNode)) | ||
| { | ||
| // Ensure this is an argument to the requested invocation | ||
| if (invocationSyntax != descendantNode.FirstAncestorOrSelf<SyntaxNode>(syntaxFacts.IsInvocationExpression)) |
There was a problem hiding this comment.
this isn't a great way to do things. consider using ISyntaxFacts which will letyou decompose things in a language agnostic fashino, while still being:
- somewhat strongly typed.
- ensuring you don't have code that is waslking down infinitely deep and all the way back up again.
There was a problem hiding this comment.
another approach is to simply use IOp to get the IInvocationOp for your invocation. Then find the IArg corresponding to your parameter. And then just see if it is .Implicit or not.
There was a problem hiding this comment.
Ah, I was making this too complicated. As you mentioned IInvocationOp already has what I need.
3 tasks
CyrusNajmabadi
approved these changes
Dec 7, 2024
This was referenced Dec 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the value tracking code such that parameters only add callers that specify that parameter as an argument.
Fixes #66771