Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[release/9.0] [wasi] Disable build in .NET 9 #108877

Merged
merged 6 commits into from
Jan 21, 2025
Merged

[release/9.0] [wasi] Disable build in .NET 9 #108877

merged 6 commits into from
Jan 21, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented Oct 15, 2024 •
edited by pavelsavara
Loading

The 'wasi-experimental' workload is not supported in .NET 9.
This change makes it explicit, so that users are not misled into thinking that the workload is supported.
The WASI experiment is continuing in Net10.

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm labels Oct 15, 2024
@maraf maraf added this to the 9.0.0 milestone Oct 15, 2024
@maraf maraf self-assigned this Oct 15, 2024
@maraf maraf changed the title [wasi] Disable build in .NET 9 [release/9.0] [wasi] Disable build in .NET 9 Oct 15, 2024
@maraf @richlander
Update src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Current.M…
568fa63 
…anifest/WorkloadManifest.Wasi.targets.in

Co-authored-by: Rich Lander <rich@lander.ca>
This was referenced Oct 17, 2024
Open
Closed
@carlossanlop
Copy link
Member

@maraf is this PR fixing an existing issue? If yes, can you please mention it in the description?

@pavelsavara pavelsavara added the Servicing-consider Issue for next servicing release review label Oct 23, 2024
@pavelsavara
Copy link
Member

@maraf is this PR fixing an existing issue? If yes, can you please mention it in the description?

Done. WASI is not released product but an experiment.

carlossanlop
carlossanlop requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maraf - Please retarget this PR to the release/9.0-staging branch.

You can retarget to that branch by clicking on the Edit button on the top right (next to the PR title) and choosing the release/9.0-staging branch from the dropdown. Important: Please make sure you don't bring any unrelated changes from the release/9.0 branch when retargeting to release/9.0-staging.

@maraf maraf changed the base branch from release/9.0 to release/9.0-staging November 5, 2024 10:37
@maraf maraf modified the milestones: 9.0.0, 9.0.x Nov 5, 2024
@build-analysis build-analysis bot mentioned this pull request Nov 5, 2024
Open
3 tasks
@carlossanlop
Copy link
Member

carlossanlop commented Jan 13, 2025 •
edited
Loading

@maraf @pavelsavara friendly reminder that today's code complete for the Feb 2025 Release. Please merge this change by 4pm PT if you'd like it included in that release version. Otherwise, it will have to wait until next month.

carlossanlop
carlossanlop approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it's targeting the correct branch now.

I just realized this is tell-mode, so it is servicing-approved by default.

@carlossanlop carlossanlop removed the Servicing-consider Issue for next servicing release review label Jan 13, 2025
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Jan 13, 2025
@carlossanlop
Copy link
Member

@maraf @pavelsavara are the CI failures concerning? If not, please merge.

This was referenced Jan 20, 2025
Open
Open
Open
Open
Open
@pavelsavara
Copy link
Member

pavelsavara commented Jan 21, 2025 •
edited
Loading

There is new version of nodeJS v23.6.0 which doesn't need those options anymore

Log

[wasm test] [18:41:43] info: /usr/bin/node: bad option: --experimental-wasm-simd
[wasm test] [18:41:43] info: /usr/bin/node: bad option: --experimental-wasm-eh

@maraf
Copy link
Member Author

maraf commented Jan 21, 2025

/ba-g Failures are unrelated, caused by newer Node JS in the image. See #111655

@maraf maraf merged commit 9efd46e into release/9.0-staging Jan 21, 2025
144 of 153 checks passed
@maraf maraf deleted the maraf/WasiDisableBuild branch January 21, 2025 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@richlander richlander richlander left review comments

@pavelsavara pavelsavara pavelsavara approved these changes

@carlossanlop carlossanlop carlossanlop approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Milestone
9.0.x
Development

Successfully merging this pull request may close these issues.
5 participants
@maraf @carlossanlop @pavelsavara @richlander @ilonatommy