Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[browser] Remove experimental args from NodeJS WBT runner #111655

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented Jan 21, 2025

The docker image has a newer Node JS which doesn't need the arguments

@maraf maraf added arch-wasm WebAssembly architecture area-Infrastructure-mono os-browser Browser variant of arch-wasm labels Jan 21, 2025
@maraf maraf added this to the 9.0.x milestone Jan 21, 2025
Copy link
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak
See info in area-owners.md if you want to be subscribed.

@akoeplinger
Copy link
Member

Infrastructure-only change, tell mode, applying servicing-approved.

@maraf
Copy link
Member Author

maraf commented Feb 9, 2025

The Wasm.Build.Tests.ConfigSrcTests.ConfigSrcAbsolutePath faikure is probably related. I'll investigate it
EDIT: It doesn't repro on windows with the same node version. On CI it's just linux
EDIT2: Works also on WSL with the same node version
EDIT3: The test was failing in previous runs. Not related to this change. I'm going to remove the test from running on NodeJS

@maraf maraf marked this pull request as ready for review February 10, 2025 12:38
@maraf maraf requested a review from ilonatommy as a code owner February 10, 2025 12:38
@maraf
Copy link
Member Author

maraf commented Feb 10, 2025

/ba-g Windows WBT passed on previous run

@maraf maraf merged commit 8f76618 into release/9.0-staging Feb 10, 2025
23 of 26 checks passed
@maraf maraf deleted the maraf/BrowserWbtNoExperimentalNodeJS branch February 10, 2025 19:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants