Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix42292 #52463

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Fix42292 #52463

merged 2 commits into from
Jun 1, 2021

Conversation

sdmaclea
Copy link
Contributor

@sdmaclea sdmaclea commented May 7, 2021

Fixes #42292

/cc @mikem8361

@sdmaclea sdmaclea added this to the 6.0.0 milestone May 7, 2021
@sdmaclea sdmaclea requested a review from janvorli May 7, 2021 19:46
@sdmaclea sdmaclea self-assigned this May 7, 2021
@mikem8361
Copy link
Member

Does this cause the same cmake warning as in issue #41084?

@sdmaclea
Copy link
Contributor Author

sdmaclea commented May 7, 2021

Does this cause the same cmake warning as in issue #41084?

I would assume so.

@sdmaclea
Copy link
Contributor Author

ping

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sdmaclea sdmaclea merged commit b802263 into dotnet:main Jun 1, 2021
@sdmaclea sdmaclea deleted the fix42292 branch June 1, 2021 00:21
thaystg added a commit to thaystg/runtime that referenced this pull request Jun 1, 2021
…asm_debugger_and_use_debugger_agent

* upstream/main: (597 commits)
  Fix42292 (dotnet#52463)
  [mono] Remove some obsolete emscripten flags. (dotnet#53486)
  Fixed path to projects (dotnet#53435)
  support ServerCertificateContext in quic (dotnet#53175)
  Socket: delete unix local endpoint filename on Close (dotnet#52103)
  [mono] Fix sgen_gc_info.memory_load_bytes (dotnet#53364)
  Refactor MsQuic's native IP address types. (dotnet#53461)
  Re-enabled optimizations for gtFoldExprConst (dotnet#53347)
  Add diagnostic support into sample app and AppBuilders on Mono. (dotnet#53361)
  Fix issues with virtuals and mdarrays (dotnet#53400)
  Split Variant marshalling tests (dotnet#53035)
  Update clrjit.natvis to cover GT_SIMD and GT_HWINTRINSIC (dotnet#53470)
  remove WSL checks in tests (dotnet#53475)
  Always spawn message loop thread for SystemEvents (dotnet#53467)
  add AcceptAsync cancellation overloads (dotnet#53340)
  Remove unnecessary reference to iOS workload pack in the Mono workload (dotnet#53425)
  Add CookieContainer.GetAllCookies (dotnet#53441)
  Remove DynamicallyAccessedMembers on JsonSerializer  (dotnet#53235)
  [wasm] Re-enable Wasm.Build.Tests (dotnet#53433)
  [libraries] Move library tests Feature Switches defaults to Functional tests (dotnet#53253)
  ...
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PAL test exception_handling/pal_sxs/test1/paltest_pal_sxs_test1 fails in CI on OSX
3 participants