Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[wasm] Re-enable Wasm.Build.Tests #53433

Merged
merged 3 commits into from
May 29, 2021
Merged

Conversation

radical
Copy link
Member

@radical radical commented May 28, 2021

.. as #53405 is fixed.

@ghost
Copy link

ghost commented May 28, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

.. as #53405 is fixed.

Author: radical
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@radical radical requested a review from lewing May 28, 2021 16:15
@radical radical added the arch-wasm WebAssembly architecture label May 28, 2021
@ghost
Copy link

ghost commented May 28, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. as #53405 is fixed.

Author: radical
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: -

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once again apologies for the breaking change

@radical radical requested a review from marek-safar as a code owner May 28, 2021 17:48
@radical
Copy link
Member Author

radical commented May 28, 2021

Unrelated test failures in:

Libraries Test Run checked coreclr Linux_musl arm64 Release
Libraries Test Run checked coreclr windows x86 Release
Libraries Test Run release mono OSX x64 Debug

@radical
Copy link
Member Author

radical commented May 29, 2021

Zero test failures!

@radical radical merged commit 26017ce into dotnet:main May 29, 2021
@radical radical deleted the enable-wasm-build-tests branch May 29, 2021 01:30
thaystg added a commit to thaystg/runtime that referenced this pull request Jun 1, 2021
…asm_debugger_and_use_debugger_agent

* upstream/main: (597 commits)
  Fix42292 (dotnet#52463)
  [mono] Remove some obsolete emscripten flags. (dotnet#53486)
  Fixed path to projects (dotnet#53435)
  support ServerCertificateContext in quic (dotnet#53175)
  Socket: delete unix local endpoint filename on Close (dotnet#52103)
  [mono] Fix sgen_gc_info.memory_load_bytes (dotnet#53364)
  Refactor MsQuic's native IP address types. (dotnet#53461)
  Re-enabled optimizations for gtFoldExprConst (dotnet#53347)
  Add diagnostic support into sample app and AppBuilders on Mono. (dotnet#53361)
  Fix issues with virtuals and mdarrays (dotnet#53400)
  Split Variant marshalling tests (dotnet#53035)
  Update clrjit.natvis to cover GT_SIMD and GT_HWINTRINSIC (dotnet#53470)
  remove WSL checks in tests (dotnet#53475)
  Always spawn message loop thread for SystemEvents (dotnet#53467)
  add AcceptAsync cancellation overloads (dotnet#53340)
  Remove unnecessary reference to iOS workload pack in the Mono workload (dotnet#53425)
  Add CookieContainer.GetAllCookies (dotnet#53441)
  Remove DynamicallyAccessedMembers on JsonSerializer  (dotnet#53235)
  [wasm] Re-enable Wasm.Build.Tests (dotnet#53433)
  [libraries] Move library tests Feature Switches defaults to Functional tests (dotnet#53253)
  ...
@ghost ghost locked as resolved and limited conversation to collaborators Jun 28, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants