[mono][jit] ArmBase methods are now intrinsic. #85458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
reviewed
Apr 27, 2023
src/mono/mono/mini/simd-intrinsics.c
Outdated
| @@ -3596,6 +3597,13 @@ emit_arm64_intrinsics ( | |||
| (is_64bit ? OP_XOP_I8_I8 : OP_XOP_I4_I4), | |||
| (is_64bit ? INTRINS_BITREVERSE_I64 : INTRINS_BITREVERSE_I32), | |||
| arg0_type, fsig, args); | |||
| case SN_Yield: { | |||
| MonoInst* ins; | |||
| MONO_INST_NEW (cfg, ins, OP_NOP); | |||
There was a problem hiding this comment.
arm64 has a yield instruction.
There was a problem hiding this comment.
Added OP_ARM64_HINT to account for this and other hint codes. This is also reflected on LLVM side.
vargaz
approved these changes
Apr 27, 2023
This was referenced Apr 27, 2023
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
CI failures are unrelated. Will merge on Tue. |
This was referenced Apr 28, 2023
This was referenced May 12, 2023
Closed
58 tasks
ghost
locked as resolved and limited conversation to collaborators
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
ArmBasemethods as intrinsic under arm64. These see use in BCL and might result in minor performance improvements.EDIT: The support for
ArmBase.Yieldis now also added on both LLVM and mini sides.