Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: optimize implement of the sync peers #3677

Merged
merged 1 commit into from
Nov 29, 2024

feat: optimize implement of the sync peers

da3184a
Select commit
Loading
Failed to load commit list.
Merged

feat: optimize implement of the sync peers #3677

feat: optimize implement of the sync peers
da3184a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 29, 2024 in 1s

35.45% (target 35.00%)

View this Pull Request on Codecov

35.45% (target 35.00%)

Details

Codecov Report

Attention: Patch coverage is 5.85106% with 177 lines in your changes missing coverage. Please review.

Project coverage is 35.45%. Comparing base (d0e41b5) to head (da3184a).

Files with missing lines Patch % Lines
manager/job/sync_peers.go 0.00% 123 Missing ⚠️
manager/service/job.go 0.00% 44 Missing ⚠️
manager/job/mocks/sync_peers_mock.go 0.00% 4 Missing ⚠️
manager/service/mocks/service_mock.go 0.00% 3 Missing ⚠️
manager/handlers/job.go 0.00% 2 Missing ⚠️
pkg/digest/digest.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3677      +/-   ##
==========================================
- Coverage   35.50%   35.45%   -0.05%     
==========================================
  Files         336      335       -1     
  Lines       37657    37617      -40     
==========================================
- Hits        13369    13337      -32     
+ Misses      23461    23457       -4     
+ Partials      827      823       -4     
Files with missing lines Coverage Δ
api/manager/docs.go 0.00% <ø> (ø)
manager/config/config.go 96.34% <100.00%> (+0.04%) ⬆️
manager/job/job.go 16.07% <ø> (ø)
manager/service/service.go 0.00% <ø> (ø)
scheduler/service/service_v1.go 85.33% <100.00%> (+0.31%) ⬆️
scheduler/service/service_v2.go 68.46% <100.00%> (+0.21%) ⬆️
pkg/digest/digest.go 71.00% <0.00%> (ø)
manager/handlers/job.go 50.42% <0.00%> (+0.42%) ⬆️
manager/service/mocks/service_mock.go 95.52% <0.00%> (+0.12%) ⬆️
manager/job/mocks/sync_peers_mock.go 0.00% <0.00%> (ø)
... and 2 more

... and 4 files with indirect coverage changes