Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Return undefined from getOrderbookMidPriceMap #2441

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Return undefined from getOrderbookMidPriceMap #2441

merged 1 commit into from
Oct 2, 2024

Conversation

adamfraser
Copy link
Contributor

@adamfraser adamfraser commented Oct 2, 2024 •
edited by coderabbitai bot
Loading

Changelist

Removes code that hits the OrderbookCache when generating candles. This change will be fixed in a later update

Summary by CodeRabbit

  • Bug Fixes

    • Streamlined test cases by removing redundant checks related to order book mid prices.
    • Adjusted expectations in tests to reflect changes in handling order book prices.

  • New Features

    • Updated the getOrderbookMidPriceMap function to return undefined for order book mid prices, indicating a shift in data retrieval logic.

  • Refactor

    • Removed Redis integration for fetching median prices, simplifying the price retrieval process in the CandlesGenerator.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant modifications to the CandlesGenerator functionality, particularly in the handling of order book mid prices. It removes tests related to updating existing candles and alters expected values to null or undefined. The candles-generator.ts file is updated to eliminate Redis dependencies for fetching prices, with the getOrderbookMidPriceMap function now returning undefined for all market pairs. These changes streamline the test suite and adjust the functionality related to order book prices in candle generation.

Changes

File Path Change Summary
indexer/services/ender/__tests__/lib/candles-generator.test.ts Removed tests for updating existing candles and adjusted expected values to null or undefined.
indexer/services/ender/src/lib/candles-generator.ts Removed Redis imports and modified getOrderbookMidPriceMap to return undefined for prices.

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • dydxwill

Poem

In the garden where candles glow,
Prices once high, now ebb and flow.
With tests refined, we clear the way,
For rabbits to hop and play all day! 🐇✨
No more Redis, just a simple map,
A new dawn breaks, let’s take a nap! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@adamfraser adamfraser marked this pull request as ready for review October 2, 2024 21:33
@adamfraser adamfraser requested a review from a team as a code owner October 2, 2024 21:33
@adamfraser adamfraser merged commit 9fecfc5 into main Oct 2, 2024
15 checks passed
@adamfraser adamfraser deleted the adam/candles-return-undefined-cache branch October 2, 2024 21:33
@adamfraser
Copy link
Contributor Author

@mergify backport release/indexer/v6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 2, 2024 •
edited
Loading

backport release/indexer/v6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 2, 2024
@adamfraser @mergify
Return undefined from getOrderbookMidPriceMap (#2441)
146bd26 
(cherry picked from commit 9fecfc5)

# Conflicts:
#	indexer/services/ender/__tests__/lib/candles-generator.test.ts
#	indexer/services/ender/src/lib/candles-generator.ts
@mergify mergify bot mentioned this pull request Oct 2, 2024
Merged
Christopher-Li pushed a commit that referenced this pull request Oct 2, 2024
@mergify @adamfraser
Return undefined from getOrderbookMidPriceMap (backport #2441) (#2442)
aad2a2a 
Co-authored-by: Adam Fraser <adamfraser0@gmail.com>
@adamfraser
Copy link
Contributor Author

@mergify backport release/indexer/v7.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 15, 2024 •
edited
Loading

backport release/indexer/v7.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 15, 2024
@adamfraser @mergify
Return undefined from getOrderbookMidPriceMap (#2441)
26972cf 
(cherry picked from commit 9fecfc5)

# Conflicts:
#	indexer/services/ender/__tests__/lib/candles-generator.test.ts
@mergify mergify bot mentioned this pull request Oct 15, 2024
Merged
adamfraser added a commit that referenced this pull request Oct 15, 2024
@mergify @adamfraser
Return undefined from getOrderbookMidPriceMap (backport #2441) (#2486)
7a2200e 
Co-authored-by: Adam Fraser <adamfraser0@gmail.com>
adamfraser added a commit that referenced this pull request Nov 20, 2024
@adamfraser
Return undefined from getOrderbookMidPriceMap (#2441)
d74cc70
This was referenced Nov 25, 2024
Merged
Merged
This was referenced Dec 9, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Feb 4, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dydxwill dydxwill dydxwill approved these changes

Assignees
No one assigned
Labels
indexer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamfraser @dydxwill