-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Return undefined from getOrderbookMidPriceMap (backport #2441) #2442
Return undefined from getOrderbookMidPriceMap (backport #2441) #2442
Conversation
(cherry picked from commit 9fecfc5) # Conflicts: # indexer/services/ender/__tests__/lib/candles-generator.test.ts # indexer/services/ender/src/lib/candles-generator.ts
Cherry-pick of 9fecfc5 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Changelist
Removes code that hits the OrderbookCache when generating candles. This change will be fixed in a later update
Summary by CodeRabbit
Bug Fixes
New Features
getOrderbookMidPriceMap
function to returnundefined
for order book mid prices, indicating a shift in data retrieval logic.Refactor
CandlesGenerator
.This is an automatic backport of pull request #2441 done by [Mergify](https://mergify.com).