Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: refactor error handling and tests #1360

Closed

Conversation

allnil
Copy link
Contributor

@allnil allnil commented Feb 3, 2025

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

Error handling refactoring

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@allnil allnil marked this pull request as ready for review February 3, 2025 13:53
@allnil allnil requested a review from a team as a code owner February 3, 2025 13:53
@allnil allnil changed the title DRAFT: chore: refactor error handling and tests chore: refactor error handling and tests Feb 3, 2025
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Feb 12, 2025
@allnil
Copy link
Contributor Author

allnil commented Feb 12, 2025

up :)

@github-actions github-actions bot removed the Stale label Feb 13, 2025
@srene
Copy link
Contributor

srene commented Feb 13, 2025

closint it, since the pr's been superseded by #1371, that adapts the changes to the new dapath/ metadata.

@srene srene closed this Feb 13, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants