Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(weavevm): avoid false positive availability check #1371

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

srene
Copy link
Contributor

@srene srene commented Feb 12, 2025

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner February 12, 2025 15:22
@srene srene marked this pull request as draft February 12, 2025 15:22
@srene srene self-assigned this Feb 12, 2025
@srene srene changed the title fix(weavevm): avoid fraud false positive availability check fix(weavevm): avoid false positive availability check Feb 13, 2025
@srene srene marked this pull request as ready for review February 13, 2025 08:44
@omritoptix omritoptix merged commit 5f078c4 into main Feb 17, 2025
4 checks passed
@omritoptix omritoptix deleted the srene/weavevm-fix-false-fraud-positive branch February 17, 2025 16:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
3 participants