Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[21959] Check if SHM transport is disabled in LARGE_DATA modes #5355

Merged
merged 3 commits into from
Nov 4, 2024
Merged

[21959] Check if SHM transport is disabled in LARGE_DATA modes #5355

merged 3 commits into from
Nov 4, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Oct 25, 2024 •
edited by MiguelCompany
Loading

Description

Compilation with FASTDDS_SHM_TRANSPORT_DISABLED should properly manage the shm transport in LARGE_DATA modes.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL
Refs #21959: Check for SHM_DISABLE in large_data setup modes
84b5427 
Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested a review from richiprosima October 25, 2024 07:27
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 25, 2024
@Mario-DL Mario-DL added this to the v3.2.0 milestone Oct 25, 2024
@Mario-DL
Refs #21959: Apply Miguels rev
f56e378 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Refs #21959: Apply suggestion
e45ed59 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@MiguelCompany MiguelCompany self-requested a review October 31, 2024 13:50
MiguelCompany
MiguelCompany approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Nov 4, 2024
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit a7dfdf5 into master Nov 4, 2024
16 of 17 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/3.x/21959 branch November 4, 2024 10:21
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
@Mario-DL @mergify
Check if SHM transport is disabled in LARGE_DATA modes (#5355)
043f8ef 
* Refs #21959: Check for SHM_DISABLE in large_data setup modes

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21959: Apply Miguels rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21959: Apply suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit a7dfdf5)
@mergify mergify bot mentioned this pull request Nov 4, 2024
Merged
11 tasks
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
@Mario-DL @mergify
Check if SHM transport is disabled in LARGE_DATA modes (#5355)
3d89b88 
* Refs #21959: Check for SHM_DISABLE in large_data setup modes

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21959: Apply Miguels rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21959: Apply suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit a7dfdf5)
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
@Mario-DL @mergify
Check if SHM transport is disabled in LARGE_DATA modes (#5355)
b6f7711 
* Refs #21959: Check for SHM_DISABLE in large_data setup modes

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21959: Apply Miguels rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21959: Apply suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit a7dfdf5)
This was referenced Nov 4, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
@Mario-DL @mergify
Check if SHM transport is disabled in LARGE_DATA modes (#5355)
3e73fae 
* Refs #21959: Check for SHM_DISABLE in large_data setup modes

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21959: Apply Miguels rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21959: Apply suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit a7dfdf5)

# Conflicts:
#	src/cpp/rtps/attributes/RTPSParticipantAttributes.cpp
@mergify mergify bot mentioned this pull request Nov 4, 2024
Merged
11 tasks
MiguelCompany pushed a commit that referenced this pull request Nov 4, 2024
@Mario-DL @MiguelCompany
Check if SHM transport is disabled in LARGE_DATA modes (#5355)
28dc5f5 
* Refs #21959: Check for SHM_DISABLE in large_data setup modes

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21959: Apply Miguels rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21959: Apply suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit a7dfdf5)

# Conflicts:
#	src/cpp/rtps/attributes/RTPSParticipantAttributes.cpp
MiguelCompany added a commit that referenced this pull request Nov 4, 2024
@mergify @Mario-DL @MiguelCompany
Check if SHM transport is disabled in LARGE_DATA modes (#5355) (#…
67ce284 
…5378)

* Check if `SHM` transport is disabled in `LARGE_DATA` modes (#5355)

* Refs #21959: Check for SHM_DISABLE in large_data setup modes

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21959: Apply Miguels rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21959: Apply suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit a7dfdf5)

# Conflicts:
#	src/cpp/rtps/attributes/RTPSParticipantAttributes.cpp

* Fix conflicts

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request Nov 6, 2024
@mergify @Mario-DL
Check if SHM transport is disabled in LARGE_DATA modes (#5355) (#…
c230154 
…5376)

* Refs #21959: Check for SHM_DISABLE in large_data setup modes

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21959: Apply Miguels rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21959: Apply suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit a7dfdf5)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
MiguelCompany pushed a commit that referenced this pull request Nov 14, 2024
@mergify @Mario-DL
Check if SHM transport is disabled in LARGE_DATA modes (#5355) (#…
a04fc33 
…5375)

* Refs #21959: Check for SHM_DISABLE in large_data setup modes

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21959: Apply Miguels rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21959: Apply suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit a7dfdf5)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
MiguelCompany pushed a commit that referenced this pull request Nov 15, 2024
@mergify @Mario-DL
Check if SHM transport is disabled in LARGE_DATA modes (#5355) (#…
f743ee1 
…5377)

* Refs #21959: Check for SHM_DISABLE in large_data setup modes

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21959: Apply Miguels rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21959: Apply suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit a7dfdf5)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
cferreiragonz pushed a commit that referenced this pull request Nov 18, 2024
@mergify @Mario-DL @cferreiragonz
Check if SHM transport is disabled in LARGE_DATA modes (#5355) (#…
6b2aafc 
…5375)

* Refs #21959: Check for SHM_DISABLE in large_data setup modes

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21959: Apply Miguels rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21959: Apply suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit a7dfdf5)

Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @MiguelCompany