Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[21959] Check if SHM transport is disabled in LARGE_DATA modes (backport #5355) #5377

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2024

Description

Compilation with FASTDDS_SHM_TRANSPORT_DISABLED should properly manage the shm transport in LARGE_DATA modes.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5355 done by [Mergify](https://mergify.com).

* Refs #21959: Check for SHM_DISABLE in large_data setup modes

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>

* Refs #21959: Apply Miguels rev

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #21959: Apply suggestion

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit a7dfdf5)
@MiguelCompany MiguelCompany added this to the v2.14.4 milestone Nov 4, 2024
@MiguelCompany MiguelCompany self-requested a review November 4, 2024 10:26
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 4, 2024
@MiguelCompany MiguelCompany merged commit f743ee1 into 2.14.x Nov 15, 2024
18 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/2.14.x/pr-5355 branch November 15, 2024 11:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants