Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Time Graph: Support display styles #35

Open
tahini opened this issue May 25, 2020 · 5 comments
Open

Time Graph: Support display styles #35

tahini opened this issue May 25, 2020 · 5 comments
Labels
Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart

Comments

@tahini
Copy link
Contributor

tahini commented May 25, 2020

Some data provider support styles. They should be used when available
@tahini tahini added the Theia UI frontend label May 25, 2020
@tahini tahini added this to the Solid base milestone May 25, 2020
@tahini tahini modified the milestones: Solid base, First MVP Sep 15, 2020
@tahini tahini mentioned this issue Oct 8, 2020
Merged
@MatthewKhouzam
Copy link
Contributor

To be clear, style in this case would be

  • Color
  • Size
  • Shape (Marker)
  • image (one can dream)

Anything else?

@ebugden
Copy link
Contributor

ebugden commented Mar 30, 2021 •
edited
Loading

⚠️This issue is related to the Time Graph which is its own library: theia-ide/timeline-chart. The code related to this issue can be found in the timeline-chart library and PRs for this issue should be submitted there.

@ebugden ebugden added the timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart label Mar 30, 2021
@mirsky-work
Copy link
Contributor

Fixed by #344?

@bhufmann
Copy link
Collaborator

bhufmann commented Sep 8, 2021

The support for timeline-charts is implemented. We might want to verify if there are still styles that can't be applied by the library.

For the xy-charts, the styles are not supported yes, afaik.

@mirsky-work
Copy link
Contributor

The support for timeline-charts is implemented. We might want to verify if there are still styles that can't be applied by the library.

For the xy-charts, the styles are not supported yes, afaik.

Right, so can we close this issue and create a separate one for xy-charts?

@ebugden ebugden removed this from the MVP milestone Sep 30, 2021
dleclairbb pushed a commit to dleclairbb/theia-trace-extension that referenced this issue Oct 25, 2023
@bhufmann
Fix bigint support in messages sent between webviews and vscode
f17d5da 
TODO: JSONBig.parse() doesn't create bigint if numbers are small. This
has to be addressed when deserializing messages. Re-use the normalizer
of the tsp-typescript-client to do that.

The following branch in the tps-typescript-client is introducing an
utility class and, if accepted, it can be used to solve the
deserialization issue:

eclipse-cdt-cloud/tsp-typescript-client#56

Contributes to fixing eclipse-cdt-cloud#35

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
dleclairbb pushed a commit to dleclairbb/theia-trace-extension that referenced this issue Oct 25, 2023
@bhufmann
Properly deserialize Experiment in signals to create BigInt timestamps
e27bf5e 
Contributes to fixing eclipse-cdt-cloud#35

Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Theia UI frontend timeline-chart Involves changes in the timeline chart project: https://github.com/theia-ide/timeline-chart
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bhufmann @MatthewKhouzam @tahini @ebugden @mirsky-work