Support style hierarchy and composition in StyleProvider #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OutputElementStyle's values map properties can now override the properties defined for the style identified by the parent key. A multi-level hierarchy of parent styles is supported. Style composition by using a comma-delimited list of parent keys is supported. The 'background-color', 'height', 'border-style', 'border-color' and 'border-width' properties are supported for time graph states. The 'symbol-type', 'color', 'height' and 'vertical-align' properties are supported for time graph annotations. The 'opacity' property and '-blend' modifier are supported for color styles. The '-factor' modifier is supported for number styles. Signed-off-by: Patrick Tasse <patrick.tasse@ericsson.com>
bhufmann
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
It looks good to me. Please update the description in the TSP specification https://github.com/theia-ide/trace-server-protocol for that.
MatthewKhouzam
approved these changes
May 3, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OutputElementStyle's values map properties can now override the
properties defined for the style identified by the parent key.
A multi-level hierarchy of parent styles is supported. Style composition
by using a comma-delimited list of parent keys is supported.
The 'background-color', 'height', 'border-style', 'border-color' and
'border-width' properties are supported for time graph states.
The 'symbol-type', 'color', 'height' and 'vertical-align' properties are
supported for time graph annotations.
The 'opacity' property and '-blend' modifier are supported for color
styles.
The '-factor' modifier is supported for number styles.
Signed-off-by: Patrick Tasse patrick.tasse@ericsson.com