Decouple trace explorer #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewKhouzam
approved these changes
Mar 17, 2021
MatthewKhouzam
approved these changes
Mar 17, 2021
MatthewKhouzam
approved these changes
Mar 17, 2021
MatthewKhouzam
approved these changes
Mar 17, 2021
I just want to distinguish the file of the interface from the file of the implementation, since the file name is not equal to the class name like in Java. Besides this suffix is used in other places in the code base, trace-server-url-provider-frontend-impl.ts. That's where I got the idea. |
bhufmann
added a commit
to bhufmann/vscode-trace-extension
that referenced
this pull request
Mar 23, 2021
- This change includes updates to propagate signals between webviews. This will allow views to be updated when one view changes. For example, when the user selects an open trace in the "Traces" view, the selection is sent to the various react-components. The "Available Views" view will use that signal as trigger to fetch the available views from the remote server. - Remove analysis and traces tree view from the extension. They are replaced by the theia-trace-extension react components and corresponding webviews. - The classes AnalysisTree and TracesTree is still in the code base to allow opening traces from the file system using the context sensitive menu and "Open in Trace Viewer" command. This will have to be clean-up in a later patch (+ using a cancelable progress monitor). - The patch also includes a fix to make source-map work when debugging the webview apps. Needs eclipse-cdt-cloud/theia-trace-extension#295 Fixes eclipse-cdt-cloud#4 Fixes eclipse-cdt-cloud#7 Fixes eclipse-cdt-cloud#11 Fixes eclipse-cdt-cloud#16 Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
PatrickTasse
requested changes
Mar 25, 2021
theia-extensions/viewer-prototype/src/browser/trace-explorer/trace-explorer-widget.tsx
Outdated
Show resolved
Hide resolved
...rc/browser/trace-explorer/trace-explorer-sub-widgets/trace-explorer-opened-traces-widget.tsx
Outdated
Show resolved
Hide resolved
...totype/src/browser/trace-explorer/trace-explorer-sub-widgets/trace-explorer-views-widget.tsx
Outdated
Show resolved
Hide resolved
theia-extensions/viewer-prototype/src/browser/trace-viewer/trace-viewer.tsx
Outdated
Show resolved
Hide resolved
PatrickTasse
requested changes
Mar 25, 2021
packages/react-components/src/trace-explorer/trace-explorer-opened-traces-widget.tsx
Outdated
Show resolved
Hide resolved
theia-extensions/viewer-prototype/src/browser/trace-explorer/trace-explorer-widget.tsx
Outdated
Show resolved
Hide resolved
PatrickTasse
requested changes
Mar 25, 2021
packages/react-components/src/trace-explorer/trace-explorer-views-widget.tsx
Outdated
Show resolved
Hide resolved
PatrickTasse
requested changes
Mar 25, 2021
packages/react-components/src/trace-explorer/trace-explorer-views-widget.tsx
Outdated
Show resolved
Hide resolved
bhufmann
added a commit
to bhufmann/vscode-trace-extension
that referenced
this pull request
Mar 26, 2021
- This change includes updates to propagate signals between webviews. This will allow views to be updated when one view changes. For example, when the user selects an open trace in the "Traces" view, the selection is sent to the various react-components. The "Available Views" view will use that signal as trigger to fetch the available views from the remote server. - Remove analysis and traces tree view from the extension. They are replaced by the theia-trace-extension react components and corresponding webviews. - The classes AnalysisTree and TracesTree is still in the code base to allow opening traces from the file system using the context sensitive menu and "Open in Trace Viewer" command. This will have to be clean-up in a later patch (+ using a cancelable progress monitor). - The patch also includes a fix to make source-map work when debugging the webview apps. Needs eclipse-cdt-cloud/theia-trace-extension#295 Fixes eclipse-cdt-cloud#4 Fixes eclipse-cdt-cloud#7 Fixes eclipse-cdt-cloud#11 Fixes eclipse-cdt-cloud#16 Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
- Remove direct dependencies between class - Streamline signal sending and receiving - Move signal manager in own package - Make sure removeListener actually removes listener This decoupling will make it easier to create standalone react components for trace-explorer-opened-traces-widget.tsx and trace-explorer-analysis-widget.tsx that can be re-used outside the Theia framework. Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
This new react component ReactOpenTracesWidget will be part of the packages/react-components. It can be used in other web applications independently from Theia. Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
This new react component ReactAvailableViewsWidget will be part of the packages/react-components. It can be used in other web applications independently from Theia. It listens to the AVAILABLE_OUTPUTS_CHANGED Signal to update the widget. Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
With this change the ReactAnalysisWidget is responsible to get the available analyses from the remote instead of the ReactOpenedTracesWidget. The ReactOpenTracesWidget was updated to send EXPERIMENT_SELECTED signal when to indicate that experiment selection was changed. ReactAnalysisWidget will update upon reception of the EXPERIMENT_SELECTED signal. Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
PatrickTasse
approved these changes
Mar 26, 2021
PatrickTasse
approved these changes
Mar 26, 2021
PatrickTasse
approved these changes
Mar 26, 2021
PatrickTasse
approved these changes
Mar 26, 2021
bhufmann
added a commit
to bhufmann/vscode-trace-extension
that referenced
this pull request
Mar 31, 2021
- This change includes updates to propagate signals between webviews. This will allow views to be updated when one view changes. For example, when the user selects an open trace in the "Traces" view, the selection is sent to the various react-components. The "Available Views" view will use that signal as trigger to fetch the available views from the remote server. - Remove analysis and traces tree view from the extension. They are replaced by the theia-trace-extension react components and corresponding webviews. - The classes AnalysisTree and TracesTree is still in the code base to allow opening traces from the file system using the context sensitive menu and "Open in Trace Viewer" command. This will have to be clean-up in a later patch (+ using a cancelable progress monitor). - The patch also includes a fix to make source-map work when debugging the webview apps. Needs eclipse-cdt-cloud/theia-trace-extension#295 Fixes eclipse-cdt-cloud#4 Fixes eclipse-cdt-cloud#7 Fixes eclipse-cdt-cloud#11 Fixes eclipse-cdt-cloud#16 Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
bhufmann
added a commit
to bhufmann/vscode-trace-extension
that referenced
this pull request
Mar 31, 2021
- This change includes updates to propagate signals between webviews. This will allow views to be updated when one view changes. For example, when the user selects an open trace in the "Traces" view, the selection is sent to the various react-components. The "Available Views" view will use that signal as trigger to fetch the available views from the remote server. - Remove analysis and traces tree view from the extension. They are replaced by the theia-trace-extension react components and corresponding webviews. - The classes AnalysisTree and TracesTree is still in the code base to allow opening traces from the file system using the context sensitive menu and "Open in Trace Viewer" command. This will have to be clean-up in a later patch (+ using a cancelable progress monitor). - The patch also includes a fix to make source-map work when debugging the webview apps. Needs eclipse-cdt-cloud/theia-trace-extension#295 Fixes eclipse-cdt-cloud#7 Fixes eclipse-cdt-cloud#11 Fixes eclipse-cdt-cloud#16 Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
bhufmann
added a commit
to bhufmann/vscode-trace-extension
that referenced
this pull request
Mar 31, 2021
- This change includes updates to propagate signals between webviews. This will allow views to be updated when one view changes. For example, when the user selects an open trace in the "Traces" view, the selection is sent to the various react-components. The "Available Views" view will use that signal as trigger to fetch the available views from the remote server. - Remove analysis and traces tree view from the extension. They are replaced by the theia-trace-extension react components and corresponding webviews. - The classes AnalysisTree and TracesTree is still in the code base to allow opening traces from the file system using the context sensitive menu and "Open in Trace Viewer" command. This will have to be clean-up in a later patch (+ using a cancelable progress monitor). - The patch also includes a fix to make source-map work when debugging the webview apps. Needs eclipse-cdt-cloud/theia-trace-extension#295 Fixes eclipse-cdt-cloud#7 Fixes eclipse-cdt-cloud#11 Fixes eclipse-cdt-cloud#16 Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
bhufmann
added a commit
to eclipse-cdt-cloud/vscode-trace-extension
that referenced
this pull request
Apr 5, 2021
- This change includes updates to propagate signals between webviews. This will allow views to be updated when one view changes. For example, when the user selects an open trace in the "Traces" view, the selection is sent to the various react-components. The "Available Views" view will use that signal as trigger to fetch the available views from the remote server. - Remove analysis and traces tree view from the extension. They are replaced by the theia-trace-extension react components and corresponding webviews. - The classes AnalysisTree and TracesTree is still in the code base to allow opening traces from the file system using the context sensitive menu and "Open in Trace Viewer" command. This will have to be clean-up in a later patch (+ using a cancelable progress monitor). - The patch also includes a fix to make source-map work when debugging the webview apps. Needs eclipse-cdt-cloud/theia-trace-extension#295 Fixes #7 Fixes #11 Fixes #16 Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests consists of multiple commits to decouple the trace explorer widgets into pure React components. These new React components will be part of the packages/react-components and can be used in other web applications independently to Theia.
ReactAnalysisWidgetinpackages/react-components/trace-explorer-analysis-widget.tsxReactOpenTracesWidgetinpackages/react-components/trace-explorer-opened-traces-widget.tsxAlong with this chain of commits, there are some code clean-ups and streamline the
SignalManagerand its usage.