Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Item Properties view #62

Closed
bhufmann opened this issue Oct 11, 2022 · 1 comment · Fixed by #86
Closed

Add Item Properties view #62

bhufmann opened this issue Oct 11, 2022 · 1 comment · Fixed by #86
Labels
components Changes required in traceviewer-react-components and/or traceviewer-base-component enhancement New feature or request vscode-extension Something in the vscode-extension repository

Comments

@bhufmann
Copy link
Collaborator

bhufmann commented Oct 11, 2022

The theia-trace-extension currently has a separate view in the explorer (left side) that populates upon selection in the graphs. For example, selecting an event in the Events Table the details will listed there. This should be supported in this project as well. An additional web-view needs to be implemented for that. Note that the traceviewer-react-components needs to provide the view implementation so that the web-view only need so use it and provide UI controls.

image

@bhufmann bhufmann added vscode-extension Something in the vscode-extension repository enhancement New feature or request components Changes required in traceviewer-react-components and/or traceviewer-base-component labels Oct 11, 2022
@bhufmann
Copy link
Collaborator Author

bhufmann commented Nov 9, 2022

The implementation requires a refactor of the corresponding class of the theia-trace-extension into a Theia indenpendent react component and webview code in vscode to use the newly create react component. A similar exercise was done with the open traces widget. See refactoring code eclipse-cdt-cloud/theia-trace-extension#295 and the update for that in this repo
[3] #20.

ngondalia added a commit to ngondalia/vscode-trace-extension that referenced this issue Feb 8, 2023
Changes made:

- Uses an theia independent react widget for Properties view from traceviewer-react-components
- Proper signal handling between item properties webview and extension

This will add the Item Properties View to the Trace Viewer.

Fixes eclipse-cdt-cloud#62

Signed-off-by: Neel Gondalia ngondalia@blackberry.com
ngondalia added a commit to ngondalia/vscode-trace-extension that referenced this issue Feb 10, 2023
Changes made:
- Uses an theia independent react widget for Properties view from traceviewer-react-components
- Proper signal handling between item properties webview and extension
- Changing term 'tooltip' to 'properties'

This will add the Item Properties View to the Trace Viewer.

Fixes eclipse-cdt-cloud#62

Signed-off-by: Neel Gondalia ngondalia@blackberry.com
ngondalia added a commit to ngondalia/vscode-trace-extension that referenced this issue Feb 15, 2023
Changes made:

- Uses an theia independent react widget for Properties view from traceviewer-react-components
- Proper signal handling between item properties webview and extension

This will add the Item Properties View to the Trace Viewer.

Fixes eclipse-cdt-cloud#62

Signed-off-by: Neel Gondalia ngondalia@blackberry.com
ngondalia added a commit to ngondalia/vscode-trace-extension that referenced this issue Feb 16, 2023
Changes made:

- Uses an theia independent react widget for Properties view from traceviewer-react-components
- Proper signal handling between item properties webview and extension

This will add the Item Properties View to the Trace Viewer.

Fixes eclipse-cdt-cloud#62

Signed-off-by: Neel Gondalia ngondalia@blackberry.com
bhufmann pushed a commit that referenced this issue Feb 21, 2023
Changes made:

- Uses an theia independent react widget for Properties view from traceviewer-react-components
- Proper signal handling between item properties webview and extension

This will add the Item Properties View to the Trace Viewer.

Fixes #62

Signed-off-by: Neel Gondalia ngondalia@blackberry.com
williamsyang-work pushed a commit to williamsyang-work/vscode-trace-extension that referenced this issue Jul 19, 2023
Changes made:

- Uses an theia independent react widget for Properties view from traceviewer-react-components
- Proper signal handling between item properties webview and extension

This will add the Item Properties View to the Trace Viewer.

Fixes eclipse-cdt-cloud#62

Signed-off-by: Neel Gondalia ngondalia@blackberry.com
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
components Changes required in traceviewer-react-components and/or traceviewer-base-component enhancement New feature or request vscode-extension Something in the vscode-extension repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant