Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix publication date handling in metadata #104

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

markpatton
Copy link
Contributor

@markpatton markpatton commented Nov 25, 2024

  • Make publication date required for JScholarship.
  • Treat publication date as a date not a string so a picker will popup
  • Use localized date format for date picker display.

The date will be stored in the metadata as a local ISO 8601 date format (no timezone). I spent a while trying to get the timezone returned, but to no avail. It should be possible, but may have to wait for an updated alpaca and date picker.

Required prs:

…date. Use localized date format for date picker display.
@rpoet-jh
Copy link
Contributor

rpoet-jh commented Feb 6, 2025

@markpatton this PR (and a few of the other ones) is still in Draft, is this ready for review?

@markpatton markpatton marked this pull request as ready for review February 6, 2025 15:27
Copy link

sonarqubecloud bot commented Feb 6, 2025

@markpatton markpatton merged commit 35a671c into main Feb 7, 2025
2 of 3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants