Fix publication date parsing of doi metadata #1297
Merged
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2025
jaredgalanis
approved these changes
Jan 29, 2025
markpatton
force-pushed
the
1063-pub-date
branch
from
930b90c to
a4e984a
Compare
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The publication date formatting stored in the metadata must match what is expected by the data picker.
The error messages about missing metadata are now better formatted.
I was worried about the publication date not being editable if it is not in the doi metadata since it is required. But despite it not seeming to be required, it is on every DOI I look at. And making a change so that missing values are editable also might be problematic.