Use theia-file-icons as the default theme
#11028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +63,7 @@ export namespace FrontendApplicationConfig { | |||
| export const DEFAULT: FrontendApplicationConfig = { | |||
| applicationName: 'Eclipse Theia', | |||
| defaultTheme: 'dark', | |||
| defaultIconTheme: 'none', | |||
| defaultIconTheme: 'theia-file-icons', | |||
There was a problem hiding this comment.
I believe we should probably add a breaking changes entry for it (breaking behavior).
Applications which expected none will now get theia-file-icons.
There was a problem hiding this comment.
Yeah, definitely makes sense 👍
msujew
force-pushed
the
msujew/set-default-icons
branch
from
01e814c to
88d4dc6
Compare
|
@msujew I've restarted CI a couple of times but the browser tests are failing, I'll investigate a bit as to why. |
msujew
force-pushed
the
msujew/set-default-icons
branch
from
88d4dc6 to
a38a5e2
Compare
|
I will close this PR for now, due to the CI issues. Maybe I'll come back to it later. |
FernandoAscencio
added a commit
to FernandoAscencio/theia
that referenced
this pull request
Mar 23, 2023
Closes eclipse-theia#11020 Linked to eclipse-theia#11028 Signed-Off-By: FernandoAscencio <fernando.ascencio,cama@ericsson.com>
1 task
FernandoAscencio
added a commit
to FernandoAscencio/theia
that referenced
this pull request
Mar 23, 2023
Closes eclipse-theia#11020 Linked to eclipse-theia#11028 Signed-Off-By: FernandoAscencio <fernando.ascencio,cama@ericsson.com> Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11020
How to test
iconThemelocalStorage entry.theia-file-iconstheme should be selected as the default themeReview checklist
Reminder for reviewers