Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

theming: set default to theia-file-icons #12346

Merged

Conversation

FernandoAscencio
Copy link
Contributor

What it does

Closes #11020
Linked to #11028

How to test

  1. Start Theia on a clean start (no temp files)
  2. Check the default theme

Review checklist

Reminder for reviewers

Closes eclipse-theia#11020
Linked to eclipse-theia#11028

Signed-Off-By: FernandoAscencio <fernando.ascencio,cama@ericsson.com>
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
@vince-fugnitto vince-fugnitto added the theming issues related to theming label Mar 24, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto merged commit b33ab2c into eclipse-theia:master Mar 29, 2023
@vince-fugnitto vince-fugnitto deleted the fa/defaultIconChange branch March 29, 2023 18:09
@vince-fugnitto vince-fugnitto added this to the 1.36.0 milestone Mar 29, 2023
kittaakos pushed a commit to kittaakos/arduino-ide that referenced this pull request May 1, 2023
upstream: eclipse-theia/theia#12346
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
theming issues related to theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

theming: set theia-file-icons as the default file icon theme
2 participants