Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Logs alignment #217

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Logs alignment #217

merged 4 commits into from
Sep 13, 2024

Conversation

DariusIMP
Copy link
Member

  • Removing zenoh.logger property, loading from the RUST_LOG environment variable.
  • Adding initLogsFromEnvOrDefault(logLevel: LogLevel) along with tryInitLogsFromEnv().
  • Making Logger class internal.

@DariusIMP DariusIMP requested a review from wyfo September 13, 2024 13:45
@github-actions GitHub Actions
Copy link

PR missing one of the required labels: {'breaking-change', 'enhancement', 'bug', 'dependencies', 'documentation', 'new feature', 'internal'}

@DariusIMP DariusIMP requested a review from Mallets September 13, 2024 13:45
@DariusIMP DariusIMP added enhancement New feature or request release Part of the next release labels Sep 13, 2024
@DariusIMP DariusIMP requested a review from wyfo September 13, 2024 14:08
@Mallets Mallets mentioned this pull request Sep 13, 2024
Closed
5 tasks
@DariusIMP
Refactoring logs. Replacing property from zenoh.logger to `zenoh.ru…
052b722 
…st_log`.
@DariusIMP
Refactoring logs. Loading log config from enviornment variable like i…
1f1baee 
…n other bindings: RUST_LOG=debug gradle ZPub (for instance).
@DariusIMP
Addressing comments:
5b51f5f 
- Renaming tryInitLogFromEnvOr to initLogFromEnvOr
- Adding Zenoh.initLogFromEnvOr("error") to all the examples
@DariusIMP DariusIMP requested a review from wyfo September 13, 2024 15:01
@Mallets Mallets enabled auto-merge (squash) September 13, 2024 15:03
@Mallets Mallets merged commit c97136e into eclipse-zenoh:main Sep 13, 2024
6 checks passed
@DariusIMP DariusIMP mentioned this pull request Sep 13, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Mallets Mallets Mallets approved these changes

@wyfo wyfo Awaiting requested review from wyfo

Assignees
No one assigned
Labels
enhancement New feature or request release Part of the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DariusIMP @Mallets @wyfo