Stop publication cache task on disconnected channels #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzypixelz
force-pushed
the
publication-cache-early-return
branch
from
2696c9d to
7841ae3
Compare
fuzzypixelz
force-pushed
the
publication-cache-early-return
branch
from
7841ae3 to
26481e7
Compare
|
Advanced Pub/Sub is now available in |
I think so, I don't think that the publication cache code has changed. |
|
Is the plan to merge it anyways? Knowing that |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging ZettaScaleLabs/rmw_zenoh#44, GDB backtraces showed that the
Netruntime was apparently blocked executing this publication cache task; applying this patch solved the issue.Even though the blocking behavior I observed might've been a consequence of different underlying issue, I think this patch should be applied anyway. This is because:
tokio::select!macro doesn't execute poll each branch on every iteration, but rather uses a random number generator to choose the branch.