Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

use KubeleteConfiguration instead of flags #156

Closed
errordeveloper opened this issue Aug 9, 2018 · 4 comments
Closed

use KubeleteConfiguration instead of flags #156

errordeveloper opened this issue Aug 9, 2018 · 4 comments
Labels
area/nodegroup kind/feature New feature or request

Comments

@errordeveloper
Copy link
Contributor

We would benefit from not having to worry about kubelet flags. At least a config file would be helpful, but componentconfig would be even better (need to check status).
@errordeveloper errordeveloper added the kind/feature New feature or request label Aug 9, 2018
errordeveloper added a commit that referenced this issue Aug 9, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
a7132d1
errordeveloper added a commit that referenced this issue Aug 10, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
e9faa20
errordeveloper added a commit that referenced this issue Aug 10, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
afcdc94
errordeveloper added a commit that referenced this issue Sep 4, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
1a2ed11
errordeveloper added a commit that referenced this issue Sep 4, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
16f80fd
errordeveloper added a commit that referenced this issue Sep 4, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
8baf89e
@errordeveloper errordeveloper mentioned this issue Dec 18, 2018
Closed
2 tasks
@errordeveloper
Copy link
Contributor Author

errordeveloper commented Dec 18, 2018 •
edited
Loading

We switched to kubelet config in #353, but it's still just a static asset, we should generate it and get rid of all the flags.

@errordeveloper errordeveloper mentioned this issue Dec 19, 2018
Closed
7 tasks
@errordeveloper errordeveloper mentioned this issue Mar 18, 2019
Closed
@errordeveloper
Copy link
Contributor Author

Turns out not all the flags were defined in the config yet, we will migrate what we can.

@errordeveloper
Copy link
Contributor Author

xref kubernetes/kubernetes#61647 (comment)

@errordeveloper errordeveloper changed the title use of componentconfig or kubelet config file use KubeleteConfiguration instead of flags Mar 19, 2019
@errordeveloper errordeveloper mentioned this issue Mar 19, 2019
Merged
4 tasks
@errordeveloper
Copy link
Contributor Author

errordeveloper commented May 13, 2019 •
edited
Loading

Moving remaining flags would requite some upstream changes, which are far-fetched at this point.

torredil pushed a commit to torredil/eksctl that referenced this issue May 20, 2022
Merge pull request eksctl-io#156 from leakingtapan/fix-integration
6292d0e 
Fix integration Test
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
area/nodegroup kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@errordeveloper