Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cluster DNS IP should be set according to what subnet is used for services #158

Closed
errordeveloper opened this issue Aug 9, 2018 · 0 comments · Fixed by #286
Closed

cluster DNS IP should be set according to what subnet is used for services #158

errordeveloper opened this issue Aug 9, 2018 · 0 comments · Fixed by #286

Comments

@errordeveloper
Copy link
Contributor

Right now we hardcode 10.100.0.10, but this may need to change.

The original bootstrap code had this logic:

DNS_CLUSTER_IP=10.100.0.10
if [[ $INTERNAL_IP == 10.* ]] ; then
    DNS_CLUSTER_IP=172.20.0.10;
fi
errordeveloper added a commit that referenced this issue Aug 9, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
a7132d1
errordeveloper added a commit that referenced this issue Aug 10, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
e9faa20
errordeveloper added a commit that referenced this issue Aug 10, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
afcdc94
errordeveloper added a commit that referenced this issue Sep 4, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
1a2ed11
errordeveloper added a commit that referenced this issue Sep 4, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
16f80fd
errordeveloper added a commit that referenced this issue Sep 4, 2018
@errordeveloper
Reference issue in all outstanding TODOs (#28, #156, #157, #158)
8baf89e
@errordeveloper errordeveloper mentioned this issue Oct 26, 2018
Merged
4 tasks
errordeveloper added a commit that referenced this issue Oct 26, 2018
@errordeveloper
Merge pull request #286 from weaveworks/vpc-cidr
43771c6 
 Add `--vpc-cidr` flag

- close #158
- close #279
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --vpc-cidr flag eksctl-io/eksctl
1 participant
@errordeveloper