Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[META 826] changes to metadata.cloud.project.* fields collected for GCP #1414

Closed
elastic-apm-tech opened this issue Sep 6, 2023 · 0 comments · Fixed by #1415
Closed

[META 826] changes to metadata.cloud.project.* fields collected for GCP #1414

elastic-apm-tech opened this issue Sep 6, 2023 · 0 comments · Fixed by #1415
Labels
agent-ruby

Comments

@elastic-apm-tech
Copy link

See meta issue for the description and details:
@elastic-apm-tech elastic-apm-tech mentioned this issue Sep 6, 2023
Closed
7 tasks
trentm added a commit to trentm/apm-agent-ruby that referenced this issue Sep 7, 2023
@trentm
changes/fixes to metadata.cloud.* fields collected for GCP
9d426e2 
- cloud.instance.id must be a string
- change cloud.project.id to be the 'projectId' (per spec change)
- drop cloud.project.name
- fix cloud.machine.type

Closes: elastic#1414
@trentm trentm mentioned this issue Sep 7, 2023
Merged
estolfo added a commit that referenced this issue Sep 18, 2023
@trentm @estolfo
changes/fixes to metadata.cloud.* fields collected for GCP (#1415)
c62fbc5 
* changes/fixes to metadata.cloud.* fields collected for GCP

- cloud.instance.id must be a string
- change cloud.project.id to be the 'projectId' (per spec change)
- drop cloud.project.name
- fix cloud.machine.type

Closes: #1414

* review feedback

Co-authored-by: Emily S <emily.s@elastic.co>

---------

Co-authored-by: Emily S <emily.s@elastic.co>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
agent-ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changes/fixes to metadata.cloud.* fields collected for GCP trentm/apm-agent-ruby
1 participant
@elastic-apm-tech