Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

changes/fixes to metadata.cloud.* fields collected for GCP #1415

Merged
merged 3 commits into from
Sep 18, 2023
Merged

changes/fixes to metadata.cloud.* fields collected for GCP #1415

merged 3 commits into from
Sep 18, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Sep 7, 2023

  • cloud.instance.id must be a string
  • change cloud.project.id to be the 'projectId' (per spec change)
  • drop cloud.project.name
  • fix cloud.machine.type

Closes: #1414

@trentm
changes/fixes to metadata.cloud.* fields collected for GCP
9d426e2 
- cloud.instance.id must be a string
- change cloud.project.id to be the 'projectId' (per spec change)
- drop cloud.project.name
- fix cloud.machine.type

Closes: elastic#1414
@trentm trentm requested a review from estolfo September 7, 2023 22:46
estolfo
estolfo requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@estolfo estolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this for the Ruby agent!

lib/elastic_apm/metadata/cloud_info.rb Show resolved Hide resolved
lib/elastic_apm/metadata/cloud_info.rb Outdated Show resolved Hide resolved
@trentm @estolfo
review feedback
a913977 
Co-authored-by: Emily S <emily.s@elastic.co>
@trentm trentm requested a review from estolfo September 11, 2023 16:37
estolfo
estolfo approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@estolfo estolfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@estolfo
Copy link
Contributor

estolfo commented Sep 13, 2023

@trentm can you rebase against main? I've just merged in a fix for the test failure on ruby 2.4.

@trentm
Copy link
Member Author

trentm commented Sep 14, 2023

@trentm can you rebase against main? I've just merged in a fix for the test failure on ruby 2.4.

Done.

@estolfo estolfo merged commit c62fbc5 into elastic:main Sep 18, 2023
@Yaty Yaty mentioned this pull request Jan 16, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@estolfo estolfo estolfo approved these changes

Assignees
No one assigned
Labels
agent-ruby
Projects
APM-Agents (OLD)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META 826] changes to metadata.cloud.project.* fields collected for GCP
2 participants
@trentm @estolfo