Add ECS orchestrator fields #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @amirbenun? 🙏
|
📊 Allure Report - 💚 No failures were reported.
|
orestisfl
approved these changes
Nov 30, 2023
orestisfl
requested changes
Nov 30, 2023
| @@ -82,7 +86,20 @@ func (r K8sResource) GetMetadata() (fetching.ResourceMetadata, error) { | |||
| }, nil | |||
| } | |||
|
|
|||
| func (r K8sResource) GetElasticCommonData() (map[string]any, error) { return nil, nil } | |||
| func (r K8sResource) GetElasticCommonData() (map[string]any, error) { | |||
There was a problem hiding this comment.
Please be aware that this might conflict with other data provider fields, see #1605
There was a problem hiding this comment.
I think it's probably fine because the fields are already in the form of orchestrator.resource.xyz but leaving this comment so you can verify that it's working as expected
|
Thanks @orestisfl. I will open another PR to properly index the new fields. |
orestisfl
approved these changes
Dec 11, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
Enrich K8s events with ECS orchestrator fields.
Screenshot/Data
Related Issues
Checklist
Introducing a new rule?