Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Azure: Fix missing ECS fields #1605

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

orestisfl
Copy link
Contributor

@orestisfl orestisfl commented Nov 29, 2023

Summary of your changes

This removes the elastic common data return values since they conflict with the data provider. Base reason is because of mapstr, here's a minimal example:

event := beat.Event{Fields: map[string]any{}}
_, _ = event.PutValue("cloud.account.id", "123")
_, _ = event.PutValue("cloud", map[string]any{})
fmt.Println(event.GetValue("cloud.account.id")) // prints error: key not found

The second call to PutValue replaces everything under cloud. including the existing values in cloud.acount.id.

Screenshot/Data

screenshot-2023-11-29T16:15:15 CET
image

Related Issues

Fixes #1609

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

@orestisfl orestisfl requested a review from a team as a code owner November 29, 2023 15:18
@orestisfl orestisfl self-assigned this Nov 29, 2023
Copy link

github-actions bot commented Nov 29, 2023

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 39
⬜ Skipped 1

@orestisfl orestisfl enabled auto-merge (squash) November 30, 2023 12:44
@orestisfl orestisfl linked an issue Nov 30, 2023 that may be closed by this pull request
@orestisfl orestisfl merged commit d39c0bb into elastic:main Nov 30, 2023
@orestisfl orestisfl mentioned this pull request Nov 30, 2023
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CIS Azure] cloud.* fields missing in events
2 participants