Skip to content

Commit

Permalink
remove mapping to trigger field (#1245)
Browse files Browse the repository at this point in the history
* remove mapping to trigger field

* removed dynamic templates containing trigger field

* address comments from pr

* Update internal/builder/testdata/existing.yml

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>

* Update internal/builder/testdata/expected.existing.mappings.yml

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>

---------

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
  • Loading branch information
gsantoro and jsoriano authored May 2, 2023
1 parent 68dcd77 commit 6fff981
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
4 changes: 0 additions & 4 deletions internal/builder/_static/ecs_mappings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,3 @@ mappings:
mapping:
type: nested
path_match: '*.macho.sections'
- trigger_to_nested:
mapping:
type: nested
match: trigger
8 changes: 5 additions & 3 deletions internal/builder/testdata/existing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ elasticsearch:
example:
type: short
dynamic_templates:
- to_nested:
path: trigger
- forwarded_ip_to_ip:
mapping:
type: nested
type: ip
match: forwarded_ip
match_mapping_type: string

7 changes: 4 additions & 3 deletions internal/builder/testdata/expected.existing.mappings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ elasticsearch:
example:
type: short
dynamic_templates:
- to_nested:
path: trigger
- forwarded_ip_to_ip:
mapping:
type: nested
type: ip
match: forwarded_ip
match_mapping_type: string
- _embedded_ecs-example_template:
mapping:
type: short
Expand Down

0 comments on commit 6fff981

Please # to comment.