Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove mapping to trigger field #1245

Merged
merged 5 commits into from
May 2, 2023

Conversation

gsantoro
Copy link
Contributor

Since we removed the field faas.trigger with type nested from ECS definition with this issue elastic/ecs#2192, we also want to remove the dynamic mapping definition.

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some element into dynamic_templates in the internal/builder/testdata/existing.yml file

gsantoro and others added 2 commits May 2, 2023 10:14
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@gsantoro gsantoro requested a review from mrodm May 2, 2023 09:53
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@gsantoro gsantoro merged commit 6fff981 into elastic:main May 2, 2023
@gsantoro gsantoro deleted the feature/remove_trigger branch May 2, 2023 14:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants