[Model] Fix naming with inheritance when using Proxy #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmandke
commented
Jul 3, 2019
| before(:all) do | ||
| class ::TestBase | ||
| extend ActiveModel::Naming | ||
| context 'without using proxy' do |
There was a problem hiding this comment.
I have just move d the tests into a context and changed the way the classes are defined so that they can be redefined with a different superclass in the other context.
tmandke
commented
Jul 3, 2019
| TestBase = Class.new do | ||
| extend ActiveModel::Naming | ||
|
|
||
| include Elasticsearch::Model |
There was a problem hiding this comment.
I could just copy the required code from Elasticsearch::Model in here but that would result in tests passing even if the Elasticsearch::Model changed.
tmandke
changed the title
|
thanks @tmandke ! |
estolfo
pushed a commit
to estolfo/elasticsearch-rails
that referenced
this pull request
Aug 8, 2019
* Add naming inheritance tests when using a proxy * Skip circular call to index_name/document_type when Proxy is used and inheritance is enabled
estolfo
added a commit
that referenced
this pull request
Aug 8, 2019
…ted (#898) * [MODEL] Add warning and documentation about STI support being deprecated (#895) * [MODEL] Add warning and documentation about STI support being deprecated * [MODEL] Minor change to STI deprecation warning * [MODEL] Freeze string constant depreaction warning * [MODEL] Update Readme text about STI deprecation * [Model] Fix naming with inheritance when using Proxy (#887) * Add naming inheritance tests when using a proxy * Skip circular call to index_name/document_type when Proxy is used and inheritance is enabled * [MODEL] Adjust previous cherry-picked commit for 6.x branch * [MODEL] Only warn if inheritance_enabled is set to true
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #717 & Closes #585