-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[MODEL] Add warning and documentation about STI support being deprecated #895
Conversation
If this option is removed it will mean that if I use STI and want to use the same ES index to store all the subtypes I will need to set the index name on all of them (not sure what else will break at this point). |
@tmandke You would have to manually put an artificial type field in each document. You can do this in the |
I am totally for the one "index" for one "type" and we are doing that. When using STI we have one base with N variations, and in our case (i bet for a lot of other people too) they have no difference when it comes to search. When we perform a search we want it to be across all the N Variations of the STI model. If I split these N variations across N indexes with exactly the same fields, this is wasteful because some of these types have very few records. All in all when using STI I feel like things for search are going to be identical/similar enough that it will be beneficial to having all of them in one index because at their core they spawn from the same type. |
Are you familiar with the Multimodel search? Maybe that provides what you're looking for? |
Yes, we do use the Multimodel search for our autocomplete where we search across all our models. I am just trying to make a case for supporting the feature to allow models that use STI to share an index. IMO for most cases where STI is used its not worth splitting the generic type into multiple indexes. |
Yes, but using a single index for entities with different properties is an anti-pattern and one that Elasticsearch server itself has deprecated and will remove in 8.0. Please see here for more information. |
…ted (elastic#895) * [MODEL] Add warning and documentation about STI support being deprecated * [MODEL] Minor change to STI deprecation warning * [MODEL] Freeze string constant depreaction warning
…ted (elastic#895) * [MODEL] Add warning and documentation about STI support being deprecated * [MODEL] Minor change to STI deprecation warning * [MODEL] Freeze string constant depreaction warning
…ted (#898) * [MODEL] Add warning and documentation about STI support being deprecated (#895) * [MODEL] Add warning and documentation about STI support being deprecated * [MODEL] Minor change to STI deprecation warning * [MODEL] Freeze string constant depreaction warning * [MODEL] Update Readme text about STI deprecation * [Model] Fix naming with inheritance when using Proxy (#887) * Add naming inheritance tests when using a proxy * Skip circular call to index_name/document_type when Proxy is used and inheritance is enabled * [MODEL] Adjust previous cherry-picked commit for 6.x branch * [MODEL] Only warn if inheritance_enabled is set to true
No description provided.