This repository has been archived by the owner on May 16, 2023. It is now read-only.
[elasticsearch] remove masterTerminationFix #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `masterTerminationFix` side-car container introduced in elastic#63 to fix slow elections issues when master node is deleted. This workaround is no more needed since Elasticsearch 7.2.
jmlrt
changed the title
|
👋🏻 @elastic/es-delivery, this PR is to remove sidecar workaround for elastic/elasticsearch#29025 in Elasticsearch < 7.2. Can you confirm that elastic/elasticsearch#29025 has been backported to 6.8 branch and that we also can remove the sidecar workarount for it? |
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
May 12, 2021
This commit is a follow-up of elastic#1183 to remove the sidecarResources value which is no more used in the chart.
jmlrt
added a commit
that referenced
this pull request
May 12, 2021
This commit is a follow-up of #1183 to remove the sidecarResources value which is no more used in the chart.
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
May 25, 2021
* [elasticsearch] fix values table formatting * [elasticsearch] remove masterTerminationFix This commit removes the `masterTerminationFix` side-car container introduced in elastic#63 to fix slow elections issues when master node is deleted. This workaround is no more needed since Elasticsearch 7.2.
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
May 25, 2021
* [elasticsearch] fix values table formatting * [elasticsearch] remove masterTerminationFix This commit removes the `masterTerminationFix` side-car container introduced in elastic#63 to fix slow elections issues when master node is deleted. This workaround is no more needed since Elasticsearch 7.2.
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
May 25, 2021
* [elasticsearch] fix values table formatting * [elasticsearch] remove masterTerminationFix This commit removes the `masterTerminationFix` side-car container introduced in elastic#63 to fix slow elections issues when master node is deleted. This workaround is no more needed since Elasticsearch 7.2.
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
May 25, 2021
This commit is a follow-up of elastic#1183 to remove the sidecarResources value which is no more used in the chart.
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
May 25, 2021
This commit is a follow-up of elastic#1183 to remove the sidecarResources value which is no more used in the chart.
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
May 25, 2021
This commit is a follow-up of elastic#1183 to remove the sidecarResources value which is no more used in the chart.
jmlrt
added a commit
that referenced
this pull request
Jun 10, 2021
* [elasticsearch] fix values table formatting * [elasticsearch] remove masterTerminationFix This commit removes the `masterTerminationFix` side-car container introduced in #63 to fix slow elections issues when master node is deleted. This workaround is no more needed since Elasticsearch 7.2.
jmlrt
added a commit
that referenced
this pull request
Jun 10, 2021
* [elasticsearch] fix values table formatting * [elasticsearch] remove masterTerminationFix This commit removes the `masterTerminationFix` side-car container introduced in #63 to fix slow elections issues when master node is deleted. This workaround is no more needed since Elasticsearch 7.2.
jmlrt
added a commit
that referenced
this pull request
Jun 10, 2021
jmlrt
added a commit
that referenced
this pull request
Jun 10, 2021
jmlrt
added a commit
to nflaig/helm-charts
that referenced
this pull request
Jul 6, 2021
* [elasticsearch] fix values table formatting * [elasticsearch] remove masterTerminationFix This commit removes the `masterTerminationFix` side-car container introduced in elastic#63 to fix slow elections issues when master node is deleted. This workaround is no more needed since Elasticsearch 7.2.
jmlrt
added a commit
to nflaig/helm-charts
that referenced
this pull request
Jul 6, 2021
This commit is a follow-up of elastic#1183 to remove the sidecarResources value which is no more used in the chart.
jmlrt
pushed a commit
to nflaig/helm-charts
that referenced
this pull request
Jul 6, 2021
* [elasticsearch] fix values table formatting * [elasticsearch] remove masterTerminationFix This commit removes the `masterTerminationFix` side-car container introduced in elastic#63 to fix slow elections issues when master node is deleted. This workaround is no more needed since Elasticsearch 7.2.
This was referenced Dec 14, 2021
Merged
Merged
This was referenced Sep 14, 2022
Merged
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
masterTerminationFixside-car containerintroduced in #63 to fix slow elections issues when master node is
deleted. This workaround is no more needed since Elasticsearch 7.2.
Also fix values table formatting in README.