This repository has been archived by the owner on May 16, 2023. It is now read-only.
[6.8] [elasticsearch] remove masterTerminationFix (#1183) #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [elasticsearch] fix values table formatting * [elasticsearch] remove masterTerminationFix This commit removes the `masterTerminationFix` side-car container introduced in elastic#63 to fix slow elections issues when master node is deleted. This workaround is no more needed since Elasticsearch 7.2.
|
waiting @elastic/es-delivery that this can be backported on 6.8 branch (#1183 (comment)) |
|
As far as I can tell elastic/elasticsearch#29025 was never backported to 6.8 so I think we'll need to keep this workaround in place. Might want to reach out to @DaveCTurner for more details though. |
|
I admit I don't follow what the code in this PR is doing exactly, but I can confirm that we have not made any changes to 6.8 in this area so elastic/elasticsearch#29025 and #63 still apply to those versions. |
|
Thanks for your help @mark-vieira @DaveCTurner. Closing this PR as there is no need to backport it to 6.8 then. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.8: