Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tracking.el should support powerline #137

Open
jorgenschaefer opened this issue Apr 17, 2015 · 5 comments
Open

tracking.el should support powerline #137

jorgenschaefer opened this issue Apr 17, 2015 · 5 comments
Milestone

Comments

@jorgenschaefer
Copy link
Collaborator

When the powerline extension is used, tracking.el's notifications are not shown. It should have the option to add itself to global-mode-string for this case.

@jorgenschaefer jorgenschaefer added this to the v1.7 milestone Apr 17, 2015
@jorgenschaefer jorgenschaefer modified the milestones: v1.7, v1.8 May 8, 2015
@travisbhartwell
Copy link

Is this something I could help with? I don't use circe, but I use weechat-el, which uses tracking.el. I also use Spacemacs which uses Powerline. So getting this to support Powerline would be useful for me.

Is it just the definition of the minor mode that needs changed, in the case of powerline being active, adding the information to global-mode-string instead of mode-line-format?

I'll ping you on IRC, I'm Nafai on #emacs.

@jorgenschaefer
Copy link
Collaborator Author

Thanks for the offer! The current setting of tracking-position will change where tracking-mode will add its indicator to the mode line. I suspect tracking-mode should auto-detect whether powerline is in use and add it to the correct place for powerline, instead of wherever tracking-position would tell it to. This behavior should also be documented in tracking-position.

travisbhartwell added a commit to travisbhartwell/circe that referenced this issue Aug 18, 2015
When the Powerline package is used, instead of modifying the
`mode-line-format', the mode-line needs to be updated in
`global-mode-string'.

Updated the documentation for tracking-position to indicate this
behavior.

Fixes emacs-circe#137.
travisbhartwell added a commit to travisbhartwell/circe that referenced this issue Aug 18, 2015
When the Powerline package is used, instead of modifying the
`mode-line-format', the mode-line needs to be updated in
`global-mode-string'.

Updated the documentation for tracking-position to indicate this
behavior.

Fixes emacs-circe#137.
travisbhartwell added a commit to travisbhartwell/circe that referenced this issue Aug 19, 2015
When the Powerline package is used, instead of modifying the
`mode-line-format', the mode-line needs to be updated in
`global-mode-string'.

Updated the documentation for tracking-position to indicate this
behavior.

Fixes emacs-circe#137.
@bradens
Copy link

bradens commented Sep 10, 2015

👍 to this! travis if you need anything I could help out with this as well.

@jorgenschaefer jorgenschaefer modified the milestones: v2.1, v2.2 Nov 15, 2015
@jorgenschaefer
Copy link
Collaborator Author

Hm. I guess this is blocked by no good way of detecting whether powerline is active or not? Can you do a workaround by either checking if (memq 'mode-line-misc-info mode-line-format) or, alternatively, just providing a new value powerline for tracking-position?

@wasamasa
Copy link
Collaborator

The latter sounds better to me as I happen to have mode-line-misc-info in mode-line-format as well although I'm using smart-mode-line.

@jorgenschaefer jorgenschaefer modified the milestones: v2.3, v2.2 Feb 26, 2016
@jorgenschaefer jorgenschaefer modified the milestones: v2.3, Backlog May 12, 2016
@jorgenschaefer jorgenschaefer modified the milestones: Backlog, v2.4 Aug 12, 2016
@jorgenschaefer jorgenschaefer removed this from the Backlog milestone Aug 12, 2016
@jorgenschaefer jorgenschaefer modified the milestones: v2.4, v2.5 Feb 25, 2017
@jorgenschaefer jorgenschaefer modified the milestones: v2.5, v2.6 May 28, 2017
@jorgenschaefer jorgenschaefer modified the milestones: v2.6, v2.7 Sep 29, 2017
@jorgenschaefer jorgenschaefer modified the milestones: v2.7, v2.8 Jan 28, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants