-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Powerline support to the tracking package. #214
base: master
Are you sure you want to change the base?
Add Powerline support to the tracking package. #214
Conversation
c539c34
to
544c8f8
Compare
Thank you for this contribution, very nice! Please do not use Also, is |
When the Powerline package is used, instead of modifying the `mode-line-format', the mode-line needs to be updated in `global-mode-string'. Updated the documentation for tracking-position to indicate this behavior. Fixes emacs-circe#137.
544c8f8
to
052f5ca
Compare
Thanks for the feedback. I admit I was just copying the idiom I saw in I've force pushed a fix to my branch for that. I'm still trying to determine the most reliable way to determine that powerline is active. I'll push that change when I figure it out and comment here so you can review that. Thanks! |
I couldn't come up with a reliable, general way to detect if Powerline is active beyond the use of |
Thanks for that! In the meantime, do you think adding a setting like Also, |
Any progress on this one? I'd like to get using circe with powerline. |
@bradens Sorry, I've been ill and haven't had the energy to get back to this, I hope to soon (next day or so). I do welcome help to make the suggestions @jorgenschaefer mentioned. |
I would also like to see this feature in, @travisbhartwell will you be able to look into this? |
When the Powerline package is used, instead of modifying the
mode-line-format', the mode-line needs to be updated in
global-mode-string'.Updated the documentation for tracking-position to indicate this
behavior.
Fixes #137.