Experimental: Improve support for USER root
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR attempts to lay the groundwork to address #96. In particular, we install the Rust toolchain globally by abusing `rustup`. We still preserve the legacy `rust` user but we now encourage derived Dockerfiles to consider `USER root`. This PR also removes ARM support. We want to explore the idea of supporting ARM more reliably using a separate image, but perhaps it would be better to refer those users to one of the Rust cross-compilation toolchains. See #63 for discussion.
gibfahn
added a commit
to gibfahn/rust-musl-builder
that referenced
this pull request
Oct 27, 2020
This is the minimal change needed to allow the docker image to be run with `--user root` and still build correctly. There may be better long-term ways of doing this, but hopefully this is small enough to be uncontroversial. This isn't a breaking change for users running normally (as the `rust` user) because these are already the default paths. Refs: emk#96 Refs: emk#100
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to lay the groundwork to address #96. In particular, we install the Rust toolchain globally by abusing
rustup.We still preserve the legacy
rustuser but we may start encouraging derived Dockerfiles to considerUSER root.This PR also removes ARM support. We want to explore the idea of supporting ARM more reliably using a separate image, but perhaps it would be better to refer those users to one of the Rust cross-compilation toolchains. See #63 for discussion.
Things to do before merging this to
master:latest, etc., with something incompatible.