Set RUSTUP_HOME and CARGO_HOME for building as root #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the minimal change needed to allow the docker image to be run with `--user root` and still build correctly. There may be better long-term ways of doing this, but hopefully this is small enough to be uncontroversial. This isn't a breaking change for users running normally (as the `rust` user) because these are already the default paths. Refs: emk#96 Refs: emk#100
|
I set these vars where the other ENV vars were set. If instead they are set at the start, then the |
|
I have merged a slightly different version of this idea. Please let me know if it works for you (assuming you're still using it)! |
|
Thanks, replied in #96 (comment) to keep the context there. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimal change needed to allow the docker image to be run
with
--user rootand still build correctly.There may be better long-term ways of doing this, but hopefully this is
small enough to be uncontroversial.
This isn't a breaking change for users running normally (as the
rustuser) because these are already the default paths.
Refs: #96
Refs: #100