Improve regex for getting labels on Node.js #1973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
I'm trying to fix some rehydration missmatch warnings using Chakra-UI (chakra-ui/chakra-ui#1446 , subsequent comments are discussing some other issue).
I found that the root of the issue was that on the node side the stack trace looked like this:
and the regex for getting the label was missing the name.
I'm not sure why the stack trace looks like this on the server side but this case can be easily handled by tweaking the regex a bit. Please let me know if I'm missing something or if it's there a workaround to this.
Why:
How:
Checklist: