Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve regex for getting labels on Node.js #1973

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Improve regex for getting labels on Node.js #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0e3171
Improve regex for getting labels on Node.js
santialbo Aug 14, 2020
8c4ffb7
Create six-geckos-battle.md
Andarist Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/six-geckos-battle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@emotion/core": patch
---

Fixed label extraction from the stack traces in node for components wrapped in `React.forwardRef`. This has affected only development builds.
2 changes: 1 addition & 1 deletion packages/core/src/jsx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ export const jsx: typeof React.createElement = function(
if (error.stack) {
// chrome
let match = error.stack.match(
/at (?:Object\.|Module\.|)jsx.*\n\s+at ([A-Z][A-Za-z$]+) /
/at (?:Object\.|Module\.|)jsx.*\n\s+at (?:Object\.|)([A-Z][A-Za-z$]+) /
)
if (!match) {
// safari and firefox
Expand Down