Skip to content

Commit

Permalink
[#499] Support Node.js 20 LTS (#501)
Browse files Browse the repository at this point in the history
+ update CI/CD to build both 18 and 20,
+ fix yarn cache location in AppVeyor,
+ remove the old notification setting.
  • Loading branch information
paulsmirnov authored Nov 20, 2023
1 parent b9201ec commit f669354
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
8 changes: 2 additions & 6 deletions .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ version: "{build}"
environment:
matrix:
- nodejs_version: "18"
- nodejs_version: "20"
cache:
- "%LOCALAPPDATA%\\Yarn"
- ".yarn\\cache"
- node_modules
init:
- git config --global core.autocrlf true
Expand All @@ -15,8 +16,3 @@ test_script:
- yarn ci

build: off
notifications:
- provider: Slack
on_build_success: false
incoming_webhook:
secure: osWQbJf4imIh5jMhkZW0RfHDY+fm5Uksv9CeOMJFysrAfMBuOWnJGfHqcI3xAiKsbY8yZkd7VefQBu+4nu0iimyvsrQouxIoCcp4rkpz+EE=
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on: [push, pull_request]

jobs:
build:
strategy:
matrix:
node: [18, 20]
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand All @@ -12,7 +15,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 18
node-version: ${{ matrix.node }}
cache: 'yarn'

- name: Install dependencies
Expand Down
7 changes: 4 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
FROM node:18 AS build
FROM node:20 AS build
COPY . /miew
RUN cd /miew \
&& yarn ci
&& yarn \
&& yarn run ci

FROM nginx:1.21-alpine
FROM nginx:1.25-alpine
LABEL maintainer="miew@epam.com"
COPY --from=build /miew/packages/lib/build /usr/share/nginx/html
COPY --from=build /miew/packages/app/build /usr/share/nginx/html/app
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"packages/*"
],
"engines": {
"npm": ">=9.0.0 <10.0.0",
"node": ">=18.0.0 <19.0.0"
"npm": ">=9.0.0 <11.0.0",
"node": ">=18.0.0 <21.0.0"
},
"scripts": {
"merge-cover": "lcov-result-merger 'coverage/lcov_*.info' > coverage/general.info",
Expand Down

0 comments on commit f669354

Please # to comment.