Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support Node.js 20 LTS #501

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Support Node.js 20 LTS #501

merged 1 commit into from
Nov 20, 2023

Conversation

paulsmirnov
Copy link
Member

Description

Closes #499.

Support development under Node.js 20,
+ update CI/CD to build both 18 and 20,
+ fix yarn cache location in AppVeyor,
+ remove the old notification setting,
+ fix broken Dockerfile.

Type of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT guides.
  • I have followed the code style of this project.
  • I have run yarn run ci: lint and tests pass locally with my changes.
  • The changes do not need test updates.
  • The changes do not need doc updates.

+ update CI/CD to build both 18 and 20,
+ fix yarn cache location in AppVeyor,
+ remove the old notification setting.
@paulsmirnov paulsmirnov self-assigned this Nov 14, 2023
@paulsmirnov paulsmirnov linked an issue Nov 14, 2023 that may be closed by this pull request
Copy link
Collaborator

@NataliaDSmirnova NataliaDSmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

Copy link
Collaborator

@DmitryLukyanov DmitryLukyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulsmirnov paulsmirnov merged commit f669354 into main Nov 20, 2023
4 checks passed
@paulsmirnov paulsmirnov deleted the 499-support-nodejs-20-lts branch November 20, 2023 12:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Node.js 20 LTS
3 participants