Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Delete CoinbasePro Plugin #266

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Conversation

macanudo527
Copy link
Collaborator

What?

Helps #265

The CoinbasePro Plugin no longer works since CoinbasePro is no longer available. This PR removes it so that users don't try to use it

@macanudo527 macanudo527 self-assigned this Nov 17, 2024
@macanudo527
Copy link
Collaborator Author

@eprbell I was going to submit this, but I think it can be revised with the Coinbase Advanced Python API. I'll have to look at it again.

@macanudo527
Copy link
Collaborator Author

@eprbell I was going to submit this, but I think it can be revised with the Coinbase Advanced Python API. I'll have to look at it again.

Sorry disregard this. This should probably be rewritten using the CCXT plugin so that it can all be standardized. We do need to rework the historical price plugin so that we have a spare # mechanism though.

@macanudo527 macanudo527 requested a review from eprbell November 27, 2024 23:49
@macanudo527 macanudo527 merged commit 0f398c7 into eprbell:main Nov 28, 2024
19 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants