cannon: Implement dclo|dclz
#14454
Open
cannon: Implement dclo|dclz
#14454
+79
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
dcloanddclzinstruction for offchain/onchain cannon implementation. We need these instructions because for executing kona compiled down to mips64r1. There were attempts(#14405) to support kona to be executed as mips64r2, but this causes more diff for cannon. The point here is to introduce as small diff as possible, while making cannon capable of executing kona in mips64, so mips64r1 is enough.There are contract diffs, so I decided to bump patch version to 1.0.1, but not sure this is the right version to update. For example at #13429 single instruction was added to onchain FPVM, and the version was bumped to
1.0.0-beta.8from1.0.0-beta.7. Anyway ran semver lock to update codehashes.Tests
Added unit tests for testing both offchain/onchain implementation and comparing them.
Validated that kona at commit op-rs/kona@161547c compiled to mips64r1 calculates expected state hash using preimage https://github.com/op-rs/kona/blob/main/bin/client/testdata/holocene-op-sepolia-22012816-witness.tar.zst with cannon with this PR applied.
Metadata