Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Kademlia article #7

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

danielrachi1
Copy link
Contributor

@danielrachi1 danielrachi1 commented Sep 19, 2023

I wrote this article several weeks ago when I was starting to learn about The Portal Network. I realized that it would be a good addition to the portal docs.

Originally, I thought about putting this in the Trin book, ethereum/trin#922, but after talking with the Trin team it was decided that this would be a better place for that article.

I also included some existing info that was available on the trin book.

To Do

  • Have someone fact-check the article.
  • Make sure that the folder structure I used is correct, and that the article is in the right spot on the website.

@vercel
Copy link

vercel bot commented Sep 19, 2023

@danielrachi is attempting to deploy a commit to the Portal Team on Vercel.

A member of the Team first needs to authorize it.

@danielrachi1 danielrachi1 changed the title Kademlia article Add Kademlia article Sep 19, 2023
@jmcook1186
Copy link
Contributor

Hi - only just saw this PR - looks awesome, thanks!

@jmcook1186 jmcook1186 requested a review from carver September 20, 2023 09:57
Copy link
Collaborator

@njgheorghita njgheorghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! @danielrachi If you don't mind also opening a pr in trin that deletes this content from our book that would be 💯

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portal-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 2:33pm

@danielrachi1
Copy link
Contributor Author

@jmcook1186 pls let me know if you want me to squash bot commits together :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants