Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: add deep dive into kademlia #922

Closed

Conversation

danielrachi1
Copy link
Contributor

What was wrong?

The existing article about Kademlia in the book was a bit shallow.

How was it fixed?

I wrote an article based on my understanding of the protocol. I believe it would complement the current information in the book.

(I wrote this several weeks ago as I was getting started with the portal network, but I realized that this might be a good thing to have in the docs.)

To-Do

  • Add entry to the release notes (may forgo for trivial changes)
  • Clean up commit history
  • Have someone check that the info in the document is accurate, and relevant to Trin.

@njgheorghita
Copy link
Collaborator

njgheorghita commented Sep 18, 2023

Thanks for the write-up! These kinds of explanations are very useful, especially to newcomers. However, this content feels more appropriately located inside of www.ethportal.net. It's general information that's relevant to all clients, and I'd like to start slimming down our docs to only containing trin-centric information. I'd recommend opening up a pr with this information (along with what existed in this page before your pr) over in https://github.com/ethereum/portal-website.

@danielrachi1
Copy link
Contributor Author

I agree, we should keep the book for trin-exclusive info and this is better placed at the general portal network docs.

Just opened ethereum/portal-website#7

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants