Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

web3_http_address should replace web3_http_port in TrinConfig #129

Closed
mrferris opened this issue Oct 8, 2021 · 14 comments · Fixed by #171
Closed

web3_http_address should replace web3_http_port in TrinConfig #129

mrferris opened this issue Oct 8, 2021 · 14 comments · Fixed by #171
Labels
good-first-issue Good for newcomers

Comments

@mrferris
Copy link
Collaborator

mrferris commented Oct 8, 2021

From #127:

@njgheorghita:

In order to communicate to our http server from outside of a docker container, we need to bind to 0.0.0.0 rather than 127.0.0.1. Though, I'm not sure if this opens up some security vulnerabilities as the new default? And instead should be controlled via cli flag / env var?

@lithp:

The long-term solution is probably to turn web3_http_port into web3_http_addr, and default to localhost. Right now this [hardcoding 0.0.0.0 instead of allowing the entire ip + port be configurable] is technically insecure because it defaults to turning any trin vulnerability into a vulnerability on a public open port.

@mrferris mrferris added the good-first-issue Good for newcomers label Oct 8, 2021
@bhunter7

This comment has been minimized.

@bhunter7

This comment has been minimized.

@lithp

This comment has been minimized.

@bhunter7

This comment has been minimized.

@bhunter7

This comment has been minimized.

@bhunter7

This comment has been minimized.

@bhunter7

This comment has been minimized.

@bhunter7

This comment has been minimized.

@bhunter7

This comment has been minimized.

@mrferris

This comment has been minimized.

@ethereum ethereum deleted a comment from bhunter7 Oct 30, 2021
@bhunter7

This comment has been minimized.

@bhunter7

This comment has been minimized.

@bhunter7
Copy link

bhunter7 commented Nov 2, 2021 via email

@ethereum ethereum locked as off-topic and limited conversation to collaborators Nov 2, 2021
@carver
Copy link
Collaborator

carver commented Nov 2, 2021

@bhunter7 We cannot provide any further help. It sounds like you've got a frustrating situation, and one that you don't fully understand.

None of us have the responsibility or capability to send you any Ethereum-based assets that you have sent away or lost.

We love to help in whatever small way that we can. We suggested other places to ask for help, but that seems to have been ignored.

To reiterate the most important lesson: do not trust people's claims about who they are, or what they will do with your assets. That's especially important when someone contacts you (rather than you contacting them). Note that you found real Ethereum developers by contacting us. Whoever initiated the conversation with you must be a scammer (and is not an actual Ethereum developer).

We wish you the best of luck in the future and are sorry for your loss.

This thread is now locked, as off-topic.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
good-first-issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants