Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update web3-http-port to web3-http-address #171

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

njgheorghita
Copy link
Collaborator

Updates cli arg web3-http-port to web3-http-address - useful for use with docker container to allow using 0.0.0.0 as the ip address.

Fixes #129

@njgheorghita njgheorghita requested a review from mrferris November 1, 2021 19:19
@njgheorghita njgheorghita requested a review from lithp November 1, 2021 19:23
@njgheorghita njgheorghita force-pushed the web3-http-address branch 4 times, most recently from ada7960 to 3653e71 Compare November 2, 2021 14:19
Copy link
Collaborator

@jacobkaufmann jacobkaufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@njgheorghita njgheorghita merged commit feeb6cd into ethereum:master Nov 2, 2021
@njgheorghita njgheorghita deleted the web3-http-address branch November 2, 2021 17:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3_http_address should replace web3_http_port in TrinConfig
2 participants